Node E2E: Fix remote log fetching. #37338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
area/test
area/node-e2e
release-note-none
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
the
size/XS
jingxu97
reviewed
Nov 23, 2016
| @@ -299,7 +299,7 @@ func RunRemote(archive string, host string, cleanup bool, junitFilePrefix string | |||
| // journald nodes. We should have a more robust way to collect logs. | |||
| var ( | |||
| logName = "system.log" | |||
| logPath = filepath.Join(workspace, logName) | |||
| logPath = fmt.Sprintf("/tmp/%s-%s", getTimestamp(), logName) | |||
There was a problem hiding this comment.
if node is rebooted, the log will still be saved?
There was a problem hiding this comment.
talked offline, it will be saved
jingxu97
added
the
lgtm
|
Jenkins GCI GCE e2e failed for commit e000ff0. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot gci gce e2e test this |
|
I see. You did change the path in #35868 :) |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #37333.
This will help debug #37333.
Mark v1.5 because this helps debug an issue #37333, which was originally #35935. /cc @saad-ali
@yujuhong @dchen1107 @jingxu97
/cc @kubernetes/sig-node
This change is